[coreboot-gerrit] Change in ...coreboot[master]: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )

Change subject: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................

Patch Set 27:

(2 comments)

https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c 
File src/drivers/intel/fsp1_1/car.c:

https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c@105 
PS27, Line 105: car_soc_pre_console_init();
              : 	car_mainboard_pre_console_init();
> Same here. […]

The car_soc_pre_console_init() is required to have SPI and LPC init.
Without these functions SPI access errors during MRC write.

https://review.coreboot.org/#/c/29662/27/src/soc/intel/braswell/bootblock/bo... 
File src/soc/intel/braswell/bootblock/bootblock.c:

https://review.coreboot.org/#/c/29662/27/src/soc/intel/braswell/bootblock/bo... 
PS27, Line 50:
> Adding bootblock_cpu_init function result into message that fucntion is not used. […]

Will add bootblock_soc_init() in next patch to call the setup_mmconfig()