Attention is currently required from: Jamie Chen, Stanley Wu, Marco Chen, Eric Lai.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/octopus/variants/phaser/memory.c:
https://review.coreboot.org/c/coreboot/+/69925/comment/da541e25_0743a691
PS3, Line 18: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1
the benefit is if HW correct the board after, you don't have to modify the code again.
agree to add board id check to override memory ID for specific board id
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36ec6bad7096e5de666ac6500c8419fc6e383ae1
Gerrit-Change-Number: 69925
Gerrit-PatchSet: 3
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 08:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment