Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32553 )
Change subject: soc/intel/skylake: Remove redundant mca_configure() in ramstage
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32553/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32553/2//COMMIT_MSG@7
PS2, Line 7: redundent
redundant
Done
https://review.coreboot.org/#/c/32553/2//COMMIT_MSG@9
PS2, Line 9: redundent
redundant
Done
https://review.coreboot.org/#/c/32553/2//COMMIT_MSG@10
PS2, Line 10: its
it’s
Done
https://review.coreboot.org/#/c/32553/2//COMMIT_MSG@12
PS2, Line 12:
Tested how? Does it reduce the boot time noticeably?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e54fd07816c6317588ab6db06365937c4300ccd
Gerrit-Change-Number: 32553
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 13:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment