Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46093 )
Change subject: soc/intel/xeon_sp: Move function debug macros
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46093/1/src/include/console/debug.h
File src/include/console/debug.h:
https://review.coreboot.org/c/coreboot/+/46093/1/src/include/console/debug.h...
PS1, Line 8: #define LOG_MEM_RESOURCE(type, dev, index, base_kb, size_kb) \
If one moves the code around and the line numbers change, reproducible builds break. […]
If you move code around, it is different code resulting in a different binary.
Reproducibility means the same code produces the same binary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie237bdf8cdc42c76f38a0c820fdc92e81095f47c
Gerrit-Change-Number: 46093
Gerrit-PatchSet: 6
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Oct 2020 01:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment