Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32229 ) Change subject: util/lint: Make usage of IS_ENABLED() an error ...................................................................... Patch Set 2: Code-Review+1 (1 comment) LGTM but maybe wait for Patrick since I'm not sure how we deal with checkpatch.pl. https://review.coreboot.org/#/c/32229/2/util/lint/checkpatch.pl File util/lint/checkpatch.pl: https://review.coreboot.org/#/c/32229/2/util/lint/checkpatch.pl@a6187 PS2, Line 6187: Should we change this to say "prefer CONFIG()" instead? I'm not sure what our stance is on modifying this file. Is the rest of it a clean copy from the kernel repo or are there already other modifications? -- To view, visit https://review.coreboot.org/c/coreboot/+/32229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id30ffa0089cec6c24fc3dbbb10a1be35f63b3d89 Gerrit-Change-Number: 32229 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 30 May 2019 19:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment