Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32414 )
Change subject: arch/x86: Add option for running romstage out of RAM ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/32414/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32414/1//COMMIT_MSG@7 PS1, Line 7: Romstage
romstage
Done
https://review.coreboot.org/#/c/32414/1//COMMIT_MSG@10 PS1, Line 10: Romstage
romstage
Done
https://review.coreboot.org/#/c/32414/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/32414/1/src/Kconfig@153 PS1, Line 153: x86
You spell x86 differently X86 in the commit messages, I believe.
Fixed in the commit message.
https://review.coreboot.org/#/c/32414/1/src/Kconfig@154 PS1, Line 154: falling
is falling? falls?
Done
https://review.coreboot.org/#/c/32414/1/src/arch/x86/assembly_entry.S File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/#/c/32414/1/src/arch/x86/assembly_entry.S@29 PS1, Line 29: IS_ENABLED
CONFIG
Done. Thanks.