Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32926 )
Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................
Patch Set 2:
"volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaac05f73d2ba892d3ec7ee2ac0c16a98f2fce5bc
Gerrit-Change-Number: 32926
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 23 May 2019 15:30:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment