Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Paul Menzel, Weimin Wu.
Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
File src/mainboard/google/dedede/variants/storo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51016/comment/007087f8_bcc5c498
PS5, Line 253: register "reg_irq_msk" = "0x6f"
Remove this, as the interrupt mask is not a register we should be trying to pre-initialize from coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8
Gerrit-Change-Number: 51016
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 00:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment