build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27358 )
Change subject: riscv: temporarily block multiple-threads
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/#/c/27358/21/src/arch/riscv/include/arch/smp/smp...
File src/arch/riscv/include/arch/smp/smp.h:
https://review.coreboot.org/#/c/27358/21/src/arch/riscv/include/arch/smp/smp...
PS21, Line 36: static inline void SMP_SYNC()
Bad function definition - void SMP_SYNC() should probably be void SMP_SYNC(void)
https://review.coreboot.org/#/c/27358/21/src/arch/riscv/include/arch/smp/smp...
PS21, Line 42: } while(atomic_read(&counter) < CONFIG_HART_NUM);
space required before the open parenthesis '('
--
To view, visit
https://review.coreboot.org/27358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eeed51e0952c66a9a9f25a90105fe471ffa70e
Gerrit-Change-Number: 27358
Gerrit-PatchSet: 21
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shawn Chang
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ronald G. Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 07 Sep 2018 05:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No