[coreboot-gerrit] [XL] Change in coreboot[main]: drivers/option: Add forms in cbtables

[Felix Held (Code Review)]

Attention is currently required from: Angel Pons.

Felix Held has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )

Change subject: drivers/option: Add forms in cbtables
......................................................................

Patch Set 30:

(2 comments)

File Documentation/drivers/cfr.md:

https://review.coreboot.org/c/coreboot/+/74121/comment/8eabffee_f52bd973?usp... :
PS30, Line 1: form representation
> I think no one bothers to follow up or make new decision, so we decided to get the V1 in with this s […]

this has been discussed in at least one coreboot leadership meeting in 2023 and i think also some separate meeting about this specific topic and i'm reasonably certain that we made the decision to use a different name. i'm not too happy about the fact that we spent time discussing this and the result of that discussion basically got ignored

https://review.coreboot.org/c/coreboot/+/74121/comment/7fca78cb_7c94793d?usp... :
PS30, Line 72:
> Sorry I dont get it, what do you mean actually?

the tags should be defined before being referenced. right now some are referenced in the allowed/required sub nodes of other tags before they are defined