Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37210 )
Change subject: soc/amd/common: Remove guards on ACPIMMIO utils
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37210/3/src/soc/amd/common/block/ac...
File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/37210/3/src/soc/amd/common/block/ac...
PS3, Line 68: /* smbus pci read/write - access registers at 0xfed80000 */
Everywhere else the comment with purpose and base address is removed. Is there any special reason why this comment was left untouched?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c1f0c9c9a6711532c5078c08cdf9e6612f3bc9c
Gerrit-Change-Number: 37210
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 15:05:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment