Attention is currently required from: Ravi kumar, Martin Roth, Ravi Kumar Bokka, Julius Werner, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support
......................................................................
Patch Set 25:
(3 comments)
File 3rdparty/qc_blobs:
https://review.coreboot.org/c/coreboot/+/45205/comment/6a4dd354_9cfb8d97
PS15, Line 1: Subproject commit 355fff30cbb98882664743ef62a65cbaa958e715
This patch should now pass the build-bot. […]
Hi Mike, do you mean this patch should be passing as is? It's still verified -1 so I'm assuming another patch will be uploaded soon?
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/89bc69c8_3351e203
PS24, Line 12: ssize_t ssize;
addressed in below patch […]
I don't see this change in the other CL yet. But also, is there any reason why the changes in https://review.coreboot.org/c/coreboot/+/49013/ should not be merged into this CL as well instead of being fixed in a future CL?
https://review.coreboot.org/c/coreboot/+/45205/comment/3a9002b3_92c7f06d
PS24, Line 15: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX "/pmiccfg",
addressed in below patch […]
Same comment as above. I think that these changes should be merged into this patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fc841b3113f2bf79b8376cd1ccdb671c53c2084
Gerrit-Change-Number: 45205
Gerrit-PatchSet: 25
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 16 Mar 2021 20:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Gerrit-MessageType: comment