Attention is currently required from: Furquan Shaikh, Martin Roth, Mariusz Szafrański, Jonathan Zhang, Paul Menzel, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb ......................................................................
Patch Set 5:
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/6543e332_ed5aad15 PS5, Line 1344: extern DEVTREE_CONST struct device *const __pci_%d_%02x_%d
We need something that will distinguish devices on different domains - so why not use domain number here (meybe move before "pci" in name? or use another flag to mark it is domain and not bus) We only have root buses here and parent is domain. So it is more like "DDF"("D"omain, root bus "D"evice and "F"unction) than full pci BDF in variable name to prevent name conflict. It is early "static" stage when we don`t have final pci root bus numbers that could be used instead of domain numbers. ptr->parent->dev->path_a == 0 means first domain - so using this we will prevent adding devices from other domain defined in devicetree so reverting what this patch was for.
This is only about exposing devices in a convenient way so that you can for instance directly reference '__pci_1_0_0' from the coreboot source. Without that it's still there in the linked list and you can appropriately find and use it. If you don't know the real bus (eg in early stages) and have not set it there is no point in trying the access this device, so also no point to try to expose it conveniently.