[coreboot-gerrit] Change in coreboot[master]: driver/intel/usb4: Add new driver for USB4 Root Port and Resource All...

[Brandon Breitenstein (Code Review)]

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37473 )

Change subject: driver/intel/usb4: Add new driver for USB4 Root Port and Resource Allocation
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I like where this is going, but I think a particular piece of it should be done more generically. Rather than just allocating resources for the new USB4 PCIe bridges, I would like to first merge https://review.coreboot.org/c/coreboot/+/35946/2, which I have updated to support configurable allocation of hotplug resources to any PCIe bridge indicating support for hotplugging. This makes it work on Thunderbolt 3 devices as well, you would be able to remove the usb4_buses addition and the resource additions done here and focus on other USB4 support items, or changing the default resource allocations if USB4 is used.

Sounds like a good plan to me...I hadn't seen any updates on that patch for some time so I went ahead and pushed this how I had developed it.