Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35096 )
Change subject: devicetree: Fix improper use of chip_operations ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35096/1/src/soc/cavium/common/pci/u... File src/soc/cavium/common/pci/uart.c:
https://review.coreboot.org/c/coreboot/+/35096/1/src/soc/cavium/common/pci/u... PS1, Line 43: Cavium ThunderX Minor: maybe use "Cavium ThunderX UART" ?
https://review.coreboot.org/c/coreboot/+/35096/1/src/southbridge/ti/pci7420/... File src/southbridge/ti/pci7420/firewire.c:
https://review.coreboot.org/c/coreboot/+/35096/1/src/southbridge/ti/pci7420/... PS1, Line 58: Shouldn't this be kept, like the one on cardbus?