Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39849 )
Change subject: [WIP] Add a voltage parameter for getting info from USB PD ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39849/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39849/1//COMMIT_MSG@7 PS1, Line 7: [WIP] Add a voltage parameter for getting info from USB PD Please add a prefix.
https://review.coreboot.org/c/coreboot/+/39849/1//COMMIT_MSG@10 PS1, Line 10: For some application Please list one as an example.
https://review.coreboot.org/c/coreboot/+/39849/1//COMMIT_MSG@10 PS1, Line 10: application applications
https://review.coreboot.org/c/coreboot/+/39849/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/39849/1/src/ec/google/chromeec/ec.c... PS1, Line 1157: *mini_volts = m.voltage_max; Why not use `voltage_max` as variable name?
https://review.coreboot.org/c/coreboot/+/39849/1/src/mainboard/google/fizz/m... File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39849/1/src/mainboard/google/fizz/m... PS1, Line 118: mini_volts What is *mini*? Minimum? I know of *min* and *max* as common abbreviations.