Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add and use it8528e ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@7 PS4, Line 7: and use Can be removed?
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@9 PS4, Line 9: * Add SuperIO IT8528E Could you extend the message with the discussion in the comments, that it’s actually an EC?
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@10 PS4, Line 10: Could you please also add the datasheet name/URL?
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@13 PS4, Line 13: The serial works without CONFIG_CONSOLE_SERIAL. Is that good or bad? Or do you mean, that it works under the OS?
https://review.coreboot.org/#/c/30957/4/src/superio/ite/it8528e/superio.c File src/superio/ite/it8528e/superio.c:
https://review.coreboot.org/#/c/30957/4/src/superio/ite/it8528e/superio.c@36 PS4, Line 36: .enable_resources = pnp_enable_resources, Use tabs for alignment in the whole block?