Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 )
Change subject: Fix potential NULL pointer dereferences and memory leak ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30098/3/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:
https://review.coreboot.org/c/coreboot/+/30098/3/src/arch/x86/acpigen.c@a399 PS3, Line 399: } Why do you remove this function? It causes build failures.
``` CC cbfs/fallback/ramstage.debug i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_BUTTERFLY/generated/ramstage.o: in function `generate_cpu_entries': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/intel/model_206ax/acpi.c:340: undefined reference to `acpigen_write_processor_cnot' make[1]: *** [src/arch/x86/Makefile.inc:314: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_BUTTERFLY/cbfs/fallback/ramstage.debug] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit' ```