[coreboot-gerrit] [S] Change in coreboot[main]: drivers/intel/fsp2_0: Add low battery indicator screen

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Jérémy Compostella, Ronak Kanabar, Subrata Banik.

Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: drivers/intel/fsp2_0: Add low battery indicator screen
......................................................................

Patch Set 8:

(2 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/86225/comment/cf070376_290ea4a7?usp... :
PS8, Line 527: 	select BMP_LOGO
This should probably be a `depends on` instead?

File src/vendorcode/google/chromeos/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/86225/comment/23ac7108_0bd5eaf8?usp... :
PS8, Line 45: 	      low_battery.bmp,CONFIG_PLATFORM_LOW_BATTERY_INDICATOR_LOGO_PATH))
This should go either in `fsp2_0/Makefile.mk` or in `src/lib/Makefile.mk` (because `bmp_logo.c` is there... actually, it's quite weird that we don't have a rule adding a `logo.bmp` file when `HAVE_CUSTOM_BMP_LOGO` is false, that should probably go in there  too).