Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 30:
nit: extra blank line
Ack
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 52:
nit: extra blank line
Ack
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 201: static void update_tcss_mux(int port, struct tcss_mux mux_data)
May be better to pass `mux_data` by reference, i.e. […]
good point I will change this to a reference
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 203: struct pmc_ipc_buffer *rbuf = malloc(sizeof(*rbuf));
Does you really need malloc here? It doesn't appear that `rbuf` has a lifetime that is longer than t […]
I think there was a reason for this with the old method of creating the buffers but with the new one you are right will just change this to a normal declaration
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 269: //Add check for connected maybe?
?
Will remove this left over comment