Attention is currently required from: Francois Toguo Fotso, Tim Wawrzynczak, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51096 )
Change subject: soc/intel/tigerlake: Fix typo in CrashLog implementation
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51096/comment/79fb4093_38e36531
PS2, Line 7: typo
Hmm, for me a typo is a wrong letter or so.
Re-use existing define
https://review.coreboot.org/c/coreboot/+/51096/comment/7235875d_5abf6a18
PS2, Line 8:
Please state the problem first.
https://review.coreboot.org/c/coreboot/+/51096/comment/7bf0272a_9e970e43
PS2, Line 9: re-use
re-uses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d
Gerrit-Change-Number: 51096
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 08:13:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment