Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86196?usp=email )
Change subject: soc/intel/cmn/cnvi: Move "double" comment ......................................................................
soc/intel/cmn/cnvi: Move "double" comment
Have two comments, then two blocks of code makes it hard to read. Seperate them.
Change-Id: I32d6b7c389f64305e8357f52b063628cd99816d6 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86196 Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/cnvi/cnvi.c 1 file changed, 6 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cnvi/cnvi.c b/src/soc/intel/common/block/cnvi/cnvi.c index 964aa17..87e9bbb 100644 --- a/src/soc/intel/common/block/cnvi/cnvi.c +++ b/src/soc/intel/common/block/cnvi/cnvi.c @@ -162,10 +162,6 @@ * } * } * - * Name (_PRR, Package (0x01) - * { - * WRST - * }) */ acpigen_write_power_res("WRST", 5, 0, NULL, 0); { @@ -280,6 +276,12 @@ } acpigen_write_power_res_end();
+/* + * Name (_PRR, Package (0x01) + * { + * WRST + * }) + */ acpigen_write_name("_PRR"); { acpigen_write_package(1);