Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40724 )
Change subject: drivers/intel/gma: Move IGD OpRegion to CBMEM ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40724/6/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/40724/6/src/northbridge/intel/gm45/... PS6, Line 675: Belongs in cb:40726 ?
https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... PS6, Line 23: uint32_t reg32 = pci_read_config32(dev, PCI_COMMAND); : reg32 |= PCI_COMMAND_MASTER; : pci_write_config32(dev, PCI_COMMAND, reg32); This now happens on the RUN_FSP_GOP path too.