Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34516 )
Change subject: mb/google/kukui: Support eDP panels via PS8640
......................................................................
Patch Set 45: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui...
PS40, Line 49: select DRIVER_PARADE_PS8640 if KUKUI_HAS_PS8640
We're going to have lots of followers that all need this so I think a HAS is better than explicit bo […]
Well, you need the long 'if BOARD_... || BOARD... || BOARD...' list somewhere anyway, whether you have it right here or above doesn't make a big difference I think. But whatever you think works better is fine. (Might also make sense to add a BASEBOARD_JACUZZI after all if we notice that all those followers look exactly the same).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34516
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aac5255e6a3e6019299670486214ecffbf9801
Gerrit-Change-Number: 34516
Gerrit-PatchSet: 45
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 02:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment