Attention is currently required from: Philipp Hug, Julius Werner, Ron Minnich.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59546 )
Change subject: arch/{arm,arm64,ppc64,riscv}: Add noop cpu_relax
......................................................................
Patch Set 2:
(2 comments)
File src/arch/arm/include/armv4/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/59546/comment/f33eda28_1c21c416
PS1, Line 6: __always_inline
Just `inline` is enough. __always_inline is weird and shouldn't be used without good reason.
Done. I had copy/pasted it from x86.
File src/arch/arm64/include/armv8/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/59546/comment/5f211cd6_e56de44d
PS1, Line 6: static __always_inline void cpu_relax(void) { }
Maybe add a TODO comment that this should be implement via SEV/WFE if it's ever actually used?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcb4546ceb2894eeb37589d0282b7e076d7a4747
Gerrit-Change-Number: 59546
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 21:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment