Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )
Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/Kconfig@104 PS15, Line 104: bootblock, or a hybrid romstage
We decided to drop hybrid romstage right?
Done
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/assembly_entr... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/assembly_entr... PS15, Line 36: CAR
Update comment.
Done
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld@... PS15, Line 66: #if !CONFIG(RESET_VECTOR_IN_RAM)
The linker script alone does not add anything in . […]
removing the guard results in the build process failing with a segfault. haven't investigated further
https://review.coreboot.org/c/coreboot/+/35035/6/src/arch/x86/reset_in_dram_... File src/arch/x86/reset_in_dram_crt0.S:
https://review.coreboot.org/c/coreboot/+/35035/6/src/arch/x86/reset_in_dram_... PS6, Line 59: call soc_hybrid_romstage_entry
soc_ prefix... […]
file doesn't exist in the current patchset any more