Attention is currently required from: Stefan Reinauer, Arthur Heymans, Julian Elischer.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 )
Change subject: ifdtool: Determine max regions from IFD ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68780/comment/30caf4ac_6d2f3def PS1, Line 17: in
unofficially
Done
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/68780/comment/c143a708_e037df55 PS1, Line 304: (max_regions_from_fdbar(fdb) < MAX_REGIONS) ? : max_regions_from_fdbar(fdb) : MAX_REGIONS;
MIN(max_regions_from_fdbar(), MAX_REGIONS) ?
Done
https://review.coreboot.org/c/coreboot/+/68780/comment/68163f95_a960430d PS1, Line 431: officially
unofficially
Done
https://review.coreboot.org/c/coreboot/+/68780/comment/d1cad991_42197bcb PS1, Line 436: int max_regions_from_fdbar(const fdbar_t *fdb)
make it a static function and add a static declaration somewhere higher in the file?
Done