Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40376 )
Change subject: util/cbfstool: Add support for filling ID region using FMAP
......................................................................
Patch Set 2: Code-Review-1
(Don't think this needs to be here, see CB:40377 discussion. Even if we wanted to have it in the FMAP, I still think it would be better to just create the blob in C and cbfstool write it rather than add all this custom functionality to CBFS just for this.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c55a49025508ff1f27c6f48d8e420f19d88ec2
Gerrit-Change-Number: 40376
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 21:46:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment