[coreboot-gerrit] Change in ...coreboot[master]: intel/apollolake: Add IPU to disable_dev function

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30992 )

Change subject: intel/apollolake: Add IPU to disable_dev function
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c@487 
PS7, Line 487: silconfig->IpuEn = 0;
> i'm not sure if any APL design is using MIPI camera and internal IPU if yes then this patch might im […]

If a design is using MIPI camera and/or IPU, then it will not disable PCI device 00:03.0 as it needs it. In this case this code path will not be reached. It will only be reached if devicetree disables PCI dev 00:03.0. And in this case I doubt that the usage of IPU is by intention.
So what we get here is just disabling IPU in FSP just for the case where the device is switched off in devicetree.