Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41797 )
Change subject: mb/google/volteer: move volteer-specific GPIOs to variant gpio.c
......................................................................
Patch Set 1:
don't we also need to add most of the "removed" entries to the rest of the variants so they preserve expected functionality?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f384f539d55a3a8d4a7608336ef22aca3d8c4f
Gerrit-Change-Number: 41797
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 00:18:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment