Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46033 )
Change subject: drivers/wifi: Drop maxsleep parameter from chip config ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+2
in theory with vpro you can wake from S5 but I don't think the wake source is the wifi device in that case anyway.
That's right.
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/wifi/generic/ge... File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/wifi/generic/ge... PS1, Line 192: SLP_TYP_S3 Looks like this definition is not provided by all platforms using this driver. I will have to add a change prior to this to ensure that SLP_TYP_S3 is defined always.