Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38306 )
Change subject: mb/asrock: WIP Add Asrock FM2A88M-HD+ FM2+ Currently this is just a draft! ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... File src/mainboard/asrock/fm2a88m-hd-plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 37: choice : prompt "DDR3 memory voltage" : default BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_150 : : config BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_135 : bool "1.35V" : help : Set DDR3 memory voltage to 1.35V : config BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_150 : bool "1.50V" : help : Set DDR3 memory voltage to 1.50V : config BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_165 : bool "1.65V" : help : Set DDR3 memory voltage to 1.65V : endchoice : : config BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_VAL : hex : default 0x9e if BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_135 : default 0x0 if BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_150 : default 0x1e if BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_165 This is copied from other boards. Does it work?
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 67: PLUS +
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... File src/mainboard/asrock/fm2a88m-hd-plus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 21: #include <superio/nuvoton/nct6779d/nct6779d.h> NCT6776 or NCT6779?
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 33: reg32 = CONFIG_BOARD_ASROCK_FM2A88M_HD_PLUS_DDR3_VOLT_VAL; Does this work?
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 63: #TODO You can use FIXME comments:
/* FIXME: Incomplete */
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... File src/mainboard/asrock/fm2a88m-hd-plus/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38306/2/src/mainboard/asrock/fm2a88... PS2, Line 33: unused What are these, though?