Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )
Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................
Patch Set 7:
Patch Set 7:
Hi Bryant, some comments:
- This change updates FSP-M UPD to redirect FSP console. What about coreboot itself?
- Suggest not to add a new file (uartio_vpd.c).
- Regarding Linuxboot console change, [CB:47055] will cover it, as kernel uses latter options to override previous options in the command line.
Hi Jonathan,
1. I've committed [CB:45405] to select coreboot's uart IO.
2. Here just follow Johnny's way, and use config token to separate it, should I move the codes to his file?
3. Got it, I'll abandon my change.
Thanks,
Bryant
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a85d6f137ef1aba95466e7b094740b685bf9bd
Gerrit-Change-Number: 45408
Gerrit-PatchSet: 7
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Nov 2020 06:43:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment