Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40237 )
Change subject: assert: Use __COUNTER__ instead of tag or line number in dead_code()
......................................................................
Patch Set 1: Code-Review+1
looks good to me, but i'm definitely no preprocessor macro magician, so only a +1 from me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0837365b0f3a0b1ce599e10e95676b9867982e1
Gerrit-Change-Number: 40237
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Apr 2020 20:53:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment