ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER ......................................................................
Patch Set 7:
(2 comments)
reviewers: please be aware that this change should only relate to correctly distinguishing those areas relating to being a payload loader vs. those areas related to being the ramstage.
that's the goal anyway. This has some utility outside the idea of rampayloads, namely: what activities relate to being a payloader vs. being a ramstage?
https://review.coreboot.org/#/c/32725/7/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/32725/7/src/include/memlayout.h@42 PS7, Line 42: /* Default is that currently ramstage, smm, and rmodules have a heap. */ fix this comment.
https://review.coreboot.org/#/c/32725/7/src/include/stddef.h File src/include/stddef.h:
https://review.coreboot.org/#/c/32725/7/src/include/stddef.h@25 PS7, Line 25: * The devicetree data structures are only mutable in ENV_PAYLOAD_LOADER. In the case of RAMPAYLOAD, where we run in (e.g.) postcar, can we use a constant device tree? Given that the goal is a simple boot environment, need it be mutable?