Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38189 )
Change subject: drivers/elog,pc80: Move cmos_post_log()
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
A commit message would have been nice, but the intention seems clear.
https://review.coreboot.org/c/coreboot/+/38189/6/src/drivers/elog/elog.c
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/38189/6/src/drivers/elog/elog.c@777
PS6, Line 777: if (ENV_RAMSTAGE || CONFIG(ELOG_PRERAM)) {
This seems odd, elog_add_boot_count() shouldn't be called otherwise,
afaics. It also seems to have fallen out of sync with the introduction
of ENV_PAYLOAD_LOADER. Though, unrelated to this change because it just
retains current checks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98044a28c29a2b1756fb25fb593f505e914a71c0
Gerrit-Change-Number: 38189
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 08 Mar 2020 11:19:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment