Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP
......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7
PS2, Line 7: working version
One space.
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7
PS2, Line 7: .
commit summaries do not end with a period
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@9
PS2, Line 9: CB 37564
Please add the commit message summary in ().
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@10
PS2, Line 10: THis
This
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@11
PS2, Line 11: fsp
FSP
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830
Gerrit-Change-Number: 37669
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 12 Dec 2019 11:49:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment