Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35533 )
Change subject: mb/google/hatch: Support separate fixed PL1 setting for tablet mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG@10
PS1, Line 10: but DPTF passive policy 1.0 cannot support it.
We don't have bug for this implementation. […]
Could we go back to 138395625 discuss this?
I'm not sure what will happen if you directly touch pl1 without notifying DPTF
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81c33f9df3e5431f04a08395141b5dc989474289
Gerrit-Change-Number: 35533
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Mon, 23 Sep 2019 05:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment