Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31194 )
Change subject: intel/apollolake: Add parameter to enable VTD in devicetree
......................................................................
Patch Set 1:
What was the default UPD setting in glk and apl fsp? I'm ok with the change, but we should be informed of what the previous defaults were.
Current header files indicate a default of 0, i.e. disabled.
Werner, please mention this in the commit message.
There is no guarantee, though, that all binaries have the
same defaults.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0bfcf1719e1ccc678a932bf3d38c6dbce3556bc
Gerrit-Change-Number: 31194
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Feb 2019 12:00:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment