Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )
Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................
Patch Set 5:
Patch Set 4:
Huh.. so you can write but cannot read? Or did you mean "unaffected -> not decoded" ?
That is my understanding i.e. you can write but cannot read.
What purpose would this "PCI_QUIRK_SPECS_VIOLATION" be used for?
I would guard pcidev_path_on_root_debug() and/or dev_find_slot() behind this. So seeing that in the platform Kconfig would serve as a reminder that some ugly hack is in place and needs attention. We can call it DEBUG_PCI_TREE but I would like to select it for affected soc/intel.
Humm okay.. I think most recent Intel platforms behave this way i.e. P2SB gets hidden.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eab3e7f1993b686103eaa257aacda379dc259fa
Gerrit-Change-Number: 34285
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 13 Jul 2019 16:55:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment