Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44353 )
Change subject: soc/amd/common/espi_util: slightly refactor espi_open_io_window ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44353/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/44353/1/src/soc/amd/common/block/lp... PS1, Line 186: else {
else is not required since there is a return in if block.
sure, it's not required and doesn't change behavior, but i find this much clearer. from a quick look it's not obvious that the last return is the else condition of the if before