Attention is currently required from: Martin L Roth, Jon Murphy.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74594 )
Change subject: util/sconfig/main: Add variant/gpio.h to static.c
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I don't think this is the right way to do this, but this allowed me to access the variant/gpio. […]
Do we really need the name in device tree? IMHO, the parameter already give the gpio_xx meaning. Like enable_pin=gpio_xx / reset_pin=gpio_xx etc...
Further, we don't have to look up back and forth to find the number to check the device gpios.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia16211ef73fa9c6221f98c36879dd740631b8ad2
Gerrit-Change-Number: 74594
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 01:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment