Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41895 )
Change subject: mb/google/volteer: Convert static ASL files to new DPTF implementation
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41895/12/src/drivers/intel/dptf/chi...
File src/drivers/intel/dptf/chip.h:
https://review.coreboot.org/c/coreboot/+/41895/12/src/drivers/intel/dptf/chi...
PS12, Line 7: MSECS_PER_SEC
This chip.h header file doesn't appear to use MSECS_PER_SEC, but I do see that devicetree.cb now does. Does including this here make it available to the devicetree.cb parser somehow, or is this perhaps a missed left-over from a previous revision of your change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I964c53afbd503d47a07b982672425f0e7a986a3f
Gerrit-Change-Number: 41895
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jun 2020 20:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment