Attention is currently required from: Nico Huber, Michał Żygowski, Martin L Roth, Patrick Rudolph, Paul Menzel, Arthur Heymans.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378 )
Change subject: drivers/smm_payload_interface: Add initial support for SMM payload
......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS11:
Out of curiosity, what happened to the idea to only read and verify updates […]
We considered moving the variable stack into coreboot, but it would be a lot of work: multiple modules, many libraries, all of it assuming the presence of a UEFI environment.
Or are you referring to CB:64072?
File Documentation/drivers/s3_save_restore.md:
https://review.coreboot.org/c/coreboot/+/70378/comment/26dfb52d_8a5752c1
PS8, Line 8: with differing register definitions
How does your implementation (this patchset) support many silicon generations with differing registe […]
Since soc/intel/ has common header path layout and `#define`s, cbtable.c just includes its necessary headers. At compile-time, the build-system's `-I` options retrieve the SoC-specific header.
https://github.com/benjamindoron/edk2/commit/a5960607ddfdd0430c3ba2 parses these to the required HOBs, which will be used by https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bd..., https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bd... and https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bd....
I can elaborate on this in this document's "design flow" section too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dd505a154175b6da8929b1157723de1645ca8fa
Gerrit-Change-Number: 70378
Gerrit-PatchSet: 11
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 27 Feb 2023 18:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment