Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47560 )
Change subject: xeon_sp/cpx: Check FSP version for WW45 and die if version mismatch ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/47560/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47560/1/src/vendorcode/intel/fsp/fs... PS1, Line 73: #define CPX_REV_BUILD 45 Instead of: CPX_REV_BUILD 45 suggest changing to: CPX_REV_BUILD_YEAR_MIN 1 CPX_REV_BUILD_YEAR_MAX 1 CPX_REV_BUILD_WW_MAX 45 CPX_REV_BUILD_WW_MIN 45
Support next FSP release is ww47. If there is no interface change, we would update CPX_REV_BUILD_WW_MAX to 47; If there is interface change, we would update both CPX_REV_BUILD_WW_MAX and CPX_REV_BUILD_WW_MIN to 47.