Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41910 )
Change subject: arch/x86: Declare permanent_smi_handler() ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/bd82x... PS4, Line 839: if (permanent_smi_handler()) {
Might be a mistake here.
CB:41971
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/i82801ix.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... PS4, Line 207: if (!permanent_smi_handler())
Need to figure out the logic in the original work.
CB:41970
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801jx/i82801jx.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... PS4, Line 206: if (!permanent_smi_handler())
Need to figure out the logic in the original work.
CB:41970
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/ibexp... PS4, Line 732: if (permanent_smi_handler()) {
Might be a mistake here.
CB:41971