HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... File src/mainboard/amd/padmelon/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... PS10, Line 16: #include <amdblocks/agesawrapper.h> : #include <amdblocks/BiosCallOuts.h> : #include <soc/southbridge.h> : #include <stdlib.h> : #include <string.h> do you use all of them ?
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... File src/mainboard/amd/padmelon/acpi/routing.asl:
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... PS10, Line 18: DefinitionBlock ("DSDT.AML","DSDT",0x01,"XXXXXX","XXXXXXXX",0x00010001 #include <arch/acpi.h> DefinitionBlock ("DSDT.AML","DSDT",0x02, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... File src/mainboard/amd/padmelon/fan_init.c:
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... PS10, Line 17: include <console/console.h> maybe not used
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... File src/mainboard/amd/padmelon/gpio.h:
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... PS10, Line 21: size_t not defined
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... File src/mainboard/amd/padmelon/gpio.c:
https://review.coreboot.org/c/coreboot/+/33993/10/src/mainboard/amd/padmelon... PS10, Line 20: #include <soc/gpio.h> you may include <gpio.h> instead