[coreboot-gerrit] Change in coreboot[master]: src/*/x86 : Support x2apic mode

[Paul Menzel (Code Review)]

Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51723 )

Change subject: src/*/x86 : Support x2apic mode
......................................................................

Patch Set 5:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/51723/comment/be0d24e7_86da3ae0 
PS5, Line 7: src/*/x86 :
1.  Please remove the space before the colon.
2.  The prefix does *not* have to resemble the path. In this case *x86:* fits perfectly.

https://review.coreboot.org/c/coreboot/+/51723/comment/88aeef05_990f0c20 
PS5, Line 9: Implement x2apic mode as existing code only supports apic mode
1.  Please add dot/period to the end of sentences.
2.  Please describe how you implemented the support.

https://review.coreboot.org/c/coreboot/+/51723/comment/e1b69738_7c356a39 
PS5, Line 14: cat /proc/cpuinfo | grep "apicid"
On what board?

Maybe even paste the related log messages.

Patchset:

PS5: 
Why are there three +2, if a 500 line change does not have a commit message consisting of one line?

File src/cpu/x86/lapic/lapic.c:

https://review.coreboot.org/c/coreboot/+/51723/comment/efd5fe09_06427cd7 
PS5, Line 50: 	printk(BIOS_DEBUG, " apic_id: 0x%x ", lapicid());
Why does this need to be changed?