Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47380 )
Change subject: mb/google/kukui: Add panel api after dsi start ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... PS2, Line 99: static void post_power_on_panel(struct panel_description *panel) : { : if (panel->post_power_on) : panel->post_power_on(); : } If this is two lines, won't be used anywhere else, and no default (unlink power_on_panel) actions needed, I think you can just move this to configure_display.
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel.h:
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... PS2, Line 24: turn on panel panel is turned on
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... PS2, Line 44: u8 i2c_bus = 4; If this will be used in multiple functions I'd like to replace it with a enum or const, e.g..
enum { ANX7625_I2C_BUS = 4, };
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... PS2, Line 45: struct edid *edid = &anx7625_data.edid; I think you don't need to do this if it'll be only used one time (the original code did that because it was used twice).
Just do
if (anx7625_dp_start(i2c_bus, &anx7625_data.edid) < 0)