Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86188?usp=email )
Change subject: mb/starlabs/*: Unify IO genx_dec configuration across all boards ......................................................................
mb/starlabs/*: Unify IO genx_dec configuration across all boards
Change-Id: I614b4cbf6ad502e69f463d71a2536b017c483907 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86188 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/lite/variants/glk/devicetree.cb M src/mainboard/starlabs/lite/variants/glkr/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 10 files changed, 26 insertions(+), 26 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb index 46aedd1..a8962af 100644 --- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb @@ -102,8 +102,9 @@ device ref uart2 on end device ref spi2 on end device ref lpc_espi on - register "gen1_dec" = "0x000c06a1" - register "gen2_dec" = "0x000c0081" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip ec/starlabs/merlin # Port pair 4Eh/4Fh diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb index c906dbb..bd25b0e 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb @@ -102,8 +102,9 @@ device ref uart2 on end device ref spi2 on end device ref lpc_espi on - register "gen1_dec" = "0x000c06a1" - register "gen2_dec" = "0x000c0081" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip ec/starlabs/merlin # Port pair 4Eh/4Fh diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 217c375..ccbad90 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -200,9 +200,9 @@ end device ref uart0 on end device ref pch_espi on - register "gen1_dec" = "0x00fc0201" - register "gen2_dec" = "0x00000381" - register "gen3_dec" = "0x00000511" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index 2c66936..5f19e50 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -189,8 +189,8 @@ device ref uart0 on end device ref pch_espi on register "gen1_dec" = "0x00040069" - register "gen2_dec" = "0x00040069" - register "gen3_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 9ab9179..f0398c7 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -165,10 +165,9 @@ smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" end device ref lpc_espi on - register "gen1_dec" = "0x000c0681" - register "gen2_dec" = "0x000c1641" - register "gen3_dec" = "0x00fc0201" - register "gen4_dec" = "0x000c0081" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip ec/starlabs/merlin # Port pair 4Eh/4Fh diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index ed61df8..3ab819e 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -105,10 +105,9 @@ end device ref uart0 on end device ref lpc_espi on - register "gen1_dec" = "0x000c0681" - register "gen2_dec" = "0x000c1641" - register "gen3_dec" = "0x00000069" - register "gen4_dec" = "0x0000006d" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip ec/starlabs/merlin # Port pair 4Eh/4Fh diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index abc4a7a..52e0411 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -211,9 +211,9 @@ end device ref uart0 on end device ref pch_espi on - register "gen1_dec" = "0x00fc0201" - register "gen2_dec" = "0x00000381" - register "gen3_dec" = "0x00000511" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index 938a18f..7a7c386 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -215,8 +215,8 @@ end device ref gspi1 on end device ref pch_espi on - register "gen1_dec" = "0x000c1641" - register "gen2_dec" = "0x000c0681" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" register "gen3_dec" = "0x000c0081" chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index 50cb8ae..c37ff72 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -238,9 +238,9 @@ end device ref uart0 on end device ref pch_espi on - register "gen1_dec" = "0x00fc0201" - register "gen2_dec" = "0x00000381" - register "gen3_dec" = "0x00000511" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081"
chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 0c9b7a5..5b8bd2c 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -175,7 +175,7 @@ end device ref uart0 on end device ref pch_espi on - register "gen1_dec" = "0x3c030070" + register "gen1_dec" = "0x00040069" register "gen2_dec" = "0x00fc0201" register "gen3_dec" = "0x000c0081"